- I wondering of the missing
PRorissue? - Was there no feedback?
A vcpkg registry isnāt a traditional use of source control. It uses the git hashes as a form of content-addressable file-system.
If you look at the version database, each baseline points to a git blob SHA of the respective directory of the given port. Thereās no way to PR, āIām going to rewrite these blobs to fix the old baselinesā. As long as youāre only adding things you can mostly use normal git porcelain (although it requires a two-step dance of committing, retrieving the blob SHA, and then amending the commit), but reworking succeeded versions requires rewriting history.
The fix is necessary, upstreamed, and canāt be done in the form of a PR, so I just did it. Also (and Iām happy to be proven wrong about this), thereās nothing in Beman that actually requires the PR review process. The registry isnāt even self-testing yet, when itās more than just an experiment in packaging Exemplar Iāll put the normal PR review controls on it.
1 Like